Fix faucet timeout in long faucet chain test #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow removing chains from the wallet in tests.
The chains only serve to increase the Faucet chain's length in a way that simulates the Faucet from being executed for a long time, so they can be forgotten after they have been created.
jvff
force-pushed
the
fix-faucet-timeout-in-long-faucet-chain-test
branch
from
59eb041
to
6686826
Compare
afck
approved these changes
Oct 26, 2024
jvff
added a commit
to jvff/linera-protocol
that referenced
this pull request
Oct 27, 2024
* Add `forget_chain` method to wallet CLI wrapper Allow removing chains from the wallet in tests. * Forget irrelevant newly created chains in test The chains only serve to increase the Faucet chain's length in a way that simulates the Faucet from being executed for a long time, so they can be forgotten after they have been created.
jvff
added a commit
that referenced
this pull request
Oct 27, 2024
* Add some tokens to the new chains (#2718) * Fix faucet timeout in long faucet chain test (#2721) * Add `forget_chain` method to wallet CLI wrapper Allow removing chains from the wallet in tests. * Forget irrelevant newly created chains in test The chains only serve to increase the Faucet chain's length in a way that simulates the Faucet from being executed for a long time, so they can be forgotten after they have been created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The long faucet chain test fails because the mutation to obtain a new chain from the faucet times out. This happens because the mutation is sent immediately after the faucet starts, and the faucet takes a while to start up. During startup, the wallet synchronizes all of its chains. This includes the (long) faucet chain, but also all the chains created earlier, which are useless from this point of the test onwards.
Proposal
Remove the newly created chains from the wallet, so that they aren't synchronized when the faucet starts.
Test Plan
Tested manually to confirm the timeout disappears.
Release Plan
devnetandtestnetbranches, to prevent CI from failing for known reasons.Links